Add tests for evaluated property nesting conflicts #785
+147
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
force-pushed
the
uneval-nested-conflicts
branch
from
f634f57 to
25d4e26
Compare
jdesrosiers
force-pushed
the
uneval-nested-conflicts
branch
from
25d4e26 to
8970b1c
Compare
jviotti
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting evaluated properties/items requires considering the instance location that the property/item is being collected for. For example, a property collected from a nested object should not result in a property of the same name at the top level being considered evaluated.
I'm surprised we don't have a test for this already!