test: add Unicode combining character sequence cases to maxLength#847
Open
abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
Open
test: add Unicode combining character sequence cases to maxLength#847abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Unicode-focused test cases to
draft2020-12/maxLength.jsonclarifying thatmaxLengthis defined in terms of Unicode code points.Technical Context
Per the JSON Schema specification,
maxLengthis based on the number of Unicode code points, not grapheme clusters or normalization results.This PR adds:
\u00e9) which is a single code point and valid formaxLength: 1.e\u0301) which consists of two code points and must be invalid formaxLength: 1.This test specifically targets the distinction between code point length and user-perceived grapheme clusters, a common point of divergence in JSON Schema implementations.
Validation
Validated JSON integrity locally using Node.js.
node -e "JSON.parse(require('fs').readFileSync('tests/draft2020-12/maxLength.json','utf8')); console.log('JSON OK')"