test(draft2020-12): add boundary coverage for maxContains = 0#857
Open
abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
Open
test(draft2020-12): add boundary coverage for maxContains = 0#857abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
abhi-03-kh wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for the boundary value
maxContains = 0in the Draft 2020-12 test suite.The specification permits
maxContainsto be any non-negative integer. While positive values are already covered, the boundary value0is currently untested.Rationale
For the schema:
{ "contains": { "const": 1 }, "maxContains": 0 }The default minContains = 1 requires at least one matching element, while maxContains = 0 prohibits any matching elements. Therefore, no array instance can satisfy both constraints.
This test ensures correct handling of the zero boundary condition and guards against implementations that do not properly enforce lower/upper bound interaction.
Scope
Adds a minimal test block to tests/draft2020-12/maxContains.json
Does not modify existing tests
No behavioral changes to current coverage