Skip to content

Conversation

@aeberhart
Copy link
Contributor

GitHub Issue: # / NA

Summary:

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
[JUSTIFICATION]

@gregsdennis
Copy link
Member

Thanks for the submission. Really interesting paper.

Not a showstopper, but I only saw one place where JSON Schema is being used, and even then, I think it's still in the context of JSONata.

    "response_format": {
      "type": "json_schema",
      "json_schema": {
        "name": "coffe_request_schema",
        "schema": {
            "type": "object",
            "properties": $all("wot", "action")[name="makeDrink"].vars,
            "additionalProperties": false
        }
      }
    }

I assume the $all... produces a dictionary of schemas? I feel it may be confusing for readers (who go to your paper from this site) that the schema as shown isn't actually a schema, with the only (very subtle) clue that it's not actually JSON because the $all... isn't a JSON string.

@aeberhart
Copy link
Contributor Author

This is a JSONata expression that loads the JSON Schema from the Postgres DB.
$all("wot", "action")[name="makeDrink"].vars is evaluated to the Schema obtained from the WoT description.
This then serves as the input to the OpenAI call

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just adding credibility to existing ambassadors. 👍

@benjagm benjagm merged commit 24a60fc into json-schema-org:main Jan 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants