Update Logo to X in README for Consistency#56
Update Logo to X in README for Consistency#56adityajha2005 wants to merge 3 commits intojson-schema-org:mainfrom
Conversation
|
@adityajha2005 Thanks for PR but as its seen the new logo of X won't look good when user is using GitHub in dark mode. Can you find a solution for this ? |
@DhairyaMajmudar Alternatively, I can use an image with an opaque background like this |
|
Awsm! Go with this |
|
mb, i'll just open another pr once it's done @DhairyaMajmudar |
Update in this PR only |
GitHub README doesn’t support dynamic theme switching, so the X logo may not be visible properly in dark mode. To fix this, we’ll need an SVG with an opaque background. Let me know what you think! |
| </a> | ||
| <a href="https://twitter.com/jsonschema" target="blank" style="margin-right: 5px;"> | ||
| <img align="center" src="https://raw.githubusercontent.com/rahuldkjain/github-profile-readme-generator/master/src/images/icons/Social/twitter.svg" alt="JSON Schema Twitter" height="30" width="40" /> | ||
| <img align="center" src="./static/images/logos/x-social-media-logo-icon.svg" alt="JSON Schema X" height="30" width="40" /> |
There was a problem hiding this comment.
I think we will need the full url here. Remember this is the readme of the repo, not the website.
|
@adityajha2005 any response on #56 (comment) ? Do you need any further help ? |
|
I looked into the feedback about the X logo. Using an opaque-background version would help it render better in dark mode. Also, since this is in the README, it would be good to use the full raw GitHub URL for the image (for example: https://raw.githubusercontent.com/json-schema-org/conference/main/static/images/logos/x-logo-bg.png). |
4 participants
What kind of change does this PR introduce?
Enhancement : Updated logo of Twitter to X because of the rebranding
Issue Number:
Screenshots/videos:
Before :
After :
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?