Add Loader to validate button #144
Merged
JeelRajodiya merged 7 commits intojson-schema-org:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
Author
|
@JeelRajodiya Please review the PR. |
Member
|
@AQIB-NAWAB Better get yourself assigned to the issue next time. |
JeelRajodiya
requested changes
Mar 13, 2025
Member
JeelRajodiya
left a comment
JeelRajodiya
left a comment
There was a problem hiding this comment.
@AQIB-NAWAB Please keep the changes minimum in your PR and only include the relevant changes to the issue
Member
|
@AQIB-NAWAB the animation is really satisfying. I left some review comments. please solve them and then we can proceed. |
Contributor
Author
|
@JeelRajodiya I have made required changes. Please let me know is there anything need to fixed. |
JeelRajodiya
requested changes
Mar 14, 2025
Contributor
Author
|
I resolved all typescript errors. I overlooked them while development. It will not happen again |
… EditorControls for better readability and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Issue Number:
Screenshots/videos:
Screencast from 2025-03-13 20-21-56.webm
Summary
Add a loader the validate button to enhance the user experience.
Does this PR introduce a breaking change?
No