Skip to content

Fixed #824 - img tags replaced by Image#1197

Merged
benjagm merged 13 commits intojson-schema-org:mainfrom
29deepanshutyagi:issue_824
Jan 18, 2025
Merged

Fixed #824 - img tags replaced by Image#1197
benjagm merged 13 commits intojson-schema-org:mainfrom
29deepanshutyagi:issue_824

Conversation

@29deepanshutyagi
Copy link
Contributor

issue #824

@29deepanshutyagi 29deepanshutyagi requested a review from a team as a code owner December 22, 2024 20:31
@github-actions
Copy link

github-actions bot commented Dec 22, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a5aac0e

@codecov
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (a5aac0e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has broken the image sizing for the case study page.
See https://29deepanshutyagi-issue-824.website-2v2.pages.dev/overview/case-studies

@Relequestual
Copy link
Member

Thanks for your work so far though =]

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Dec 23, 2024

kindly review it @Relequestual
Screenshot from 2024-12-23 22-53-05

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. However, these changes still breaks the image sizing for the tooling page also.
See https://29deepanshutyagi-issue-824.website-2v2.pages.dev/tools

Could you pleaes review over all affected pages and check for breaking changes?

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Dec 23, 2024

kindly review it @DarhkVoyd and @benjagm
Screenshot from 2024-12-23 23-32-37

the last bug is fixed ,and some changes i had also done

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@29deepanshutyagi
Copy link
Contributor Author

29deepanshutyagi commented Jan 1, 2025

and i think , this pr also solves the issue #1041 , what are your views on it @benjagm

@DarhkVoyd
Copy link
Member

@29deepanshutyagi Hey there, thank you for your work on this PR, it will soon be reviewed and merged. Please understand that we're a group of volunteers. Team will see it, and they'll get to it when they can. When asking for a review, please avoid unnecessary tagging.

@29deepanshutyagi
Copy link
Contributor Author

if there is no any issue , please merge it , @benjagm , as since two weeks no any feedback is given , what can i update or what can i improve

@benjagm benjagm merged commit ee7f95a into json-schema-org:main Jan 18, 2025
9 checks passed
@github-actions
Copy link

Congratulations, @29deepanshutyagi for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants