Issue #1041 Add missing alt attribute to images#1211
Closed
CharitSinghChauhan wants to merge 5 commits intojson-schema-org:mainfrom
Closed
Issue #1041 Add missing alt attribute to images#1211CharitSinghChauhan wants to merge 5 commits intojson-schema-org:mainfrom
CharitSinghChauhan wants to merge 5 commits intojson-schema-org:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
improve Code Quality
https://github.com/CharitSinghChauhan/website into CharitSingChauhan-add-missing-alt-attribute-to-images
CharitSinghChauhan
deleted the
CharitSingChauhan-add-missing-alt-attribute-to-images
branch
CharitSinghChauhan
restored the
CharitSingChauhan-add-missing-alt-attribute-to-images
branch
Author
|
how can I improve my code quality to pass the code quality check?" |
…prove the code quality
Collaborator
|
Thanks a lot for this PR. Do you mind closing it and wait until the related issue is properly assigned? |
Author
|
Thank you for reviewing the PR! I completely understand. I’ll go ahead and close it for now and will wait until the related issue is properly assigned. Please feel free to let me know if there’s anything else I can do in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a bugfix to ensure all images in the specified pages have descriptive alt attributes for improved accessibility.
Issue Number: closes #1041
Screenshots/videos:
N/A
If relevant, did you update the documentation?
No documentation updates are necessary as this is a code-level change.
Summary:
The changes in this PR address the missing alt attributes in images on two pages located in the components/Layout.tsx and
pages/index.page.tsx directory. Adding descriptive alt attributes enhances accessibility and ensures compliance with web standards.
Does this PR introduce a breaking change?
No breaking changes introduced.