Skip to content

Whenever Some Search Or Filter Yields 0 Results, Display a Message Sa…#1308

Closed
PRINCEjain0 wants to merge 2 commits intojson-schema-org:mainfrom
PRINCEjain0:fix-issue-1282
Closed

Whenever Some Search Or Filter Yields 0 Results, Display a Message Sa…#1308
PRINCEjain0 wants to merge 2 commits intojson-schema-org:mainfrom
PRINCEjain0:fix-issue-1282

Conversation

@PRINCEjain0
Copy link

What kind of change does this PR introduce?

This enhancement allows users to receive feedback("No results found") when actions produce no results.

Issue Number:

Screenshots/videos:
Before:
Before

After:
After

If relevant, did you update the documentation?

No.

Summary:

To enhance the user experience, implement clear and informative messages whenever a search or filter returns zero results.

Does this PR introduce a breaking change?

No.

@PRINCEjain0 PRINCEjain0 requested a review from a team as a code owner January 13, 2025 17:00
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (380d81c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jan 13, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 380d81c

@DhairyaMajmudar
Copy link
Member

@PRINCEjain0 Pls. don't open PR without issue assignment and follow our contributing guidelines

@PRINCEjain0
Copy link
Author

@DhairyaMajmudar can u assign me please as I have solved this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Providing Suitable Feedbacks To User Whenever Possible

2 participants