Added dynamic icons to filters in tools page[Closes #1260]#1309
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 387 396 +9
Branches 103 106 +3
=========================================
+ Hits 387 396 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benjagm
left a comment
benjagm
left a comment
There was a problem hiding this comment.
Can you please revert the changes in the community submodule?
Sure Sir! I'll revert the changes. |
There was a problem hiding this comment.
Can you please revert the changes in the community submodule?
There was a problem hiding this comment.
Yes, i have reverted The Changes.
There was a problem hiding this comment.
How are these changes relevant to the linked issue for Tools Page?
| { hidden: !isDropdownOpen }, | ||
| 'ml-0 mt-0 overflow-hidden transition-all duration-500 ease-in-out', | ||
| { | ||
| 'max-h-0 opacity-0 invisible': !isDropdownOpen, |
There was a problem hiding this comment.
Doesn't this make it more complicated?
DhairyaMajmudar
left a comment
DhairyaMajmudar
left a comment
There was a problem hiding this comment.
@bhat-shubham your CI checks are failing pls. fix them, also remove changes from submodule folders
|
@DhairyaMajmudar I have reverted the changes in the submodule as well as fixed the failing checks. |
|
hey @benjagm @DarhkVoyd I have made the changes you asked for and need suggestion for the one if it needs to be done that way. |
benjagm
moved this from In Review Team
to Waiting for others to Review
in PR - Triage Group
|
hey @DarhkVoyd, thank you for approving the changes however, you previously mentioned about the object being redundant and how i could use the filters obj instead. |
Hey, that's not a big deal. I just suggested instead of separately managing the filterIcons object with filters as keys, we could have just stored them with the existing filters: ex: const filters = [
{ label: 'Language', accessorKey: 'languages', icon: LanguageIcon },
...
];That would keep the filters data all together and we can just access them during iteration. The filters data as single source of truth. This is fine too. That is just what I would have preferred but that's just my preference. |
|
Got it! @DarhkVoyd , I had mentioned this in a previous review as well, asking if that was the approach you preferred. And it's the same, I won’t be pushing that commit as per your guidance. |
bhat-shubham
left a comment
bhat-shubham
left a comment
There was a problem hiding this comment.
Marked as not necessary since the changes are approved. Closing the review now.
DhairyaMajmudar
left a comment
DhairyaMajmudar
left a comment
There was a problem hiding this comment.
Thanks for PR, just a minor comment, rest we're almost done.
Co-authored-by: Dhairya Majmudar <124715224+DhairyaMajmudar@users.noreply.github.com>
github-project-automation
bot
moved this from Waiting for others to Review
to Done
in PR - Triage Group
4 participants
What kind of change does this PR introduce?
This PR Closes Issue #1260 , adding dynamic and meaningful icons to each and every Filter on the Tools Page.
Issue Number:
Screenshots/videos:
Before-
After-
If relevant, did you update the documentation?
NA
Summary
Adds dynamic icons to the filters in Tools Page.
Does this PR introduce a breaking change?
NO
NA