Fix - fix markdown render in tools page#1351
Merged
benjagm merged 2 commits intojson-schema-org:mainfrom Feb 1, 2025
Merged
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
DhairyaMajmudar
requested changes
Jan 22, 2025
Member
DhairyaMajmudar
left a comment
DhairyaMajmudar
left a comment
There was a problem hiding this comment.
Its getting difficult to differentiate between plain text and URL link, pls. fix them
Contributor
Author
I used the StyledMarkdown component and now it looks correct
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix: Ensures that tooling listing notes are processed as markdown.
Issue Number:
Screenshots/videos:
Screencast.from.2025-01-21.15-36-50.webm
If relevant, did you update the documentation?
No
Summary
This PR addresses the issue where tooling listing notes were not being processed as markdown. The raw markdown text was displayed instead of rendering correctly. The issue occurred due to a missing markdown parser in the rendering pipeline for these notes. The changes fix that
Does this PR introduce a breaking change?
No