Bug : Fix dark page issue on pro help page#1352
Bug : Fix dark page issue on pro help page#1352jagpreetrahi wants to merge 4 commits intojson-schema-org:mainfrom
Conversation
There was a problem hiding this comment.
LGTM, but some checks are failing. Go to files-changed page and check the linting errors. Address these issues and commit the changes.
|
@jagpreetrahi try running the tests and build commands before committing your changes, will be helpful for you to find out errors locally |
|
Hii @Karan-Palan , firstly thank you for reviews , I have got an errors where I get , now i have to fix asap, then I 'll quickly commit |
|
Hii @Karan-Palan , Currently I am facing two error related to 'prettier' , the errors looks like |
|
@jagpreetrahi in your terminal , type
Before pushing a commit, try running the tests, building the app and checking if everything is formatted correctly. Since you have a linting error, use |
|
@jagpreetrahi it seems your format checks are failing pls. fix them by running the command |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hii @Karan-Palan @DhairyaMajmudar , thanks for helping me to resolve this error, now it is fix and all test cases are successfully passed. |
|
Hey @DhairyaMajmudar , can you review my pull request again , whenever you have get time. |
|
Hi @Karan-Palan, I would appreciate it if you could review my pull request again. If it produces valuable output, I would be grateful if you could merge it. Thank you! |
|
@jagpreetrahi I'm just a contributor here. Please don't tag maintainers until it's at least a week of inactivity. I understand as contributors we're eager to contribute but it might irritate the maintainers. This is a mistake I did as well, hence informing for your further contributions |
|
Ok @Karan-Palan , I got it |
DhairyaMajmudar
left a comment
DhairyaMajmudar
left a comment
There was a problem hiding this comment.
Thanks for the fix @jagpreetrahi left some comments then we're good to go.
There was a problem hiding this comment.
Changes in this file are irrelevant pls. remove them
github-project-automation
bot
moved this from In Review Team
to Done
in PR - Triage Group
4 participants
Hello Maintainers,
I have fixed the issues outlined in #1289
Please review the changes and let me know if there are any adjustments required. I would greatly appreciate it if you could merge this pull request after review.
Thank you for your time and effort in maintaining this project!
What kind of change does this PR introduce?
Issue Number:
- Closes #1289
Screenshots/videos:
2025-01-21-22-45-16_VcSB1rNR.mp4
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No