Bug - solve the bowtie loading error#1353
Merged
benjagm merged 1 commit intojson-schema-org:mainfrom Feb 1, 2025
Merged
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
hey @Relequestual I hope you're doing well! Could you please review this PR? |
benjagm
approved these changes
Feb 1, 2025
Collaborator
benjagm
left a comment
benjagm
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bowtie reports for tools are not loading
Issue Number:
Screenshots/videos:
Screen.Recording.2025-01-21.at.6.08.43.PM.mov
If relevant, did you update the documentation?
Summary
To solve this, I replaced the onLoad logic with an asynchronous fetch request to check whether the image URL is valid and exists. While addressing this issue, I encountered a problem where the image loading wasn't being handled as expected using the onLoad event. Therefore, I implemented the asynchronous approach because onLoad was unable to properly render the component, which was preventing the data from being displayed.
Does this PR introduce a breaking change?