Skip to content

Fixes blog navigation.#1354

Merged
benjagm merged 2 commits intojson-schema-org:mainfrom
cbum-dev:Blog-nav-fix
Feb 1, 2025
Merged

Fixes blog navigation.#1354
benjagm merged 2 commits intojson-schema-org:mainfrom
cbum-dev:Blog-nav-fix

Conversation

@cbum-dev
Copy link
Contributor

What kind of change does this PR introduce?

Fixes navigation of Documentation category of blog.

Issue Number:

Screenshots/videos:

Screencast.From.2025-01-21.23-41-09.mp4

Summary

Does this PR introduce a breaking change?

@cbum-dev cbum-dev requested a review from a team as a code owner January 21, 2025 18:12
@github-actions
Copy link

github-actions bot commented Jan 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview b4e7439

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (82fb9c7) to head (b4e7439).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @cbum-dev

LGTM 💯

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 0f44216 into json-schema-org:main Feb 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge PR that already has two approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Documentation toggle not working.

3 participants