Skip to content

Bug : solve the dropdown issue#1358

Merged
benjagm merged 1 commit intojson-schema-org:mainfrom
arpitkuriyal:dropdown
Feb 1, 2025
Merged

Bug : solve the dropdown issue#1358
benjagm merged 1 commit intojson-schema-org:mainfrom
arpitkuriyal:dropdown

Conversation

@arpitkuriyal
Copy link
Contributor

What kind of change does this PR introduce?
The transition effect for expanding and collapsing the Specification dropdown is working fine now

Issue Number:

Screenshots/videos:

Screen.Recording.2025-01-22.at.4.31.30.PM.mov

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?
No

@arpitkuriyal arpitkuriyal requested a review from a team as a code owner January 22, 2025 11:07
@github-actions
Copy link

github-actions bot commented Jan 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 03ec904

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (03ec904).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
@benjagm benjagm merged commit 91ad4a9 into json-schema-org:main Feb 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge PR that already has two approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Transition in the Specification Dropdown is Not Working Properly

3 participants