Skip to content

feat: Made side panel fixed on the tooling page#1359

Closed
thepiyush-303 wants to merge 9 commits intojson-schema-org:mainfrom
thepiyush-303:fix/fixedSidebar
Closed

feat: Made side panel fixed on the tooling page#1359
thepiyush-303 wants to merge 9 commits intojson-schema-org:mainfrom
thepiyush-303:fix/fixedSidebar

Conversation

@thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 22, 2025

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

Screencast.from.2025-01-22.20-25-15.webm

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@thepiyush-303 thepiyush-303 requested a review from a team as a code owner January 22, 2025 14:56
@github-actions
Copy link

github-actions bot commented Jan 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a0285a1

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (60f2d6a) to head (a0285a1).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thepiyush-303
Copy link
Contributor Author

@DhairyaMajmudar
can you please give a feedback on changes?

@thepiyush-303
Copy link
Contributor Author

@DhairyaMajmudar
I have made necessary changes please approve them.

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Jan 31, 2025

Fix this overlapping

image

you can take reference from sidebar from /docs page

@benjagm benjagm moved this to In Review Team in PR - Triage Group Mar 5, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good on desktop devices, but it is breaking the layout for mobile. Can you please check it?

@benjagm benjagm moved this from In Review Team to Changes requested in PR - Triage Group Mar 5, 2025
@thepiyush-303
Copy link
Contributor Author

Hello @benjagm
I forgot checking it for smaller screen but now it is fixed.
Attaching video-->

Screencast.from.2025-03-06.16-33-46.webm

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepiyush-303 pls. fix this odd behavoiur

Screencast.from.2025-03-10.22-52-32.webm

@thepiyush-303
Copy link
Contributor Author

Hello @DhairyaMajmudar
now it is fixed.

@thepiyush-303 thepiyush-303 requested a review from benjagm March 10, 2025 19:13
@thepiyush-303
Copy link
Contributor Author

Hey @DhairyaMajmudar @benjagm
Please let me know if any other changes required.

@DarhkVoyd
Copy link
Member

@thepiyush-303 Thank you for your patience, I'll review this tomorrow EOD.

@benjagm benjagm moved this from Changes requested to To Closed in PR - Triage Group May 30, 2025
@Utkarsh-123github
Copy link
Member

Hi @thepiyush-303 , as per Benjamin's comment : #1279 (comment) , I think we can close this PR.
Thank you for your contribution🚀

@thepiyush-303
Copy link
Contributor Author

Okay, Thanks @Utkarsh-123github for letting me know.
Closing it as it will be covered in GSoC2025 Project.

@Utkarsh-123github
Copy link
Member

Yes, @thepiyush-303 please close this at your convenience.

@github-project-automation github-project-automation bot moved this from To Be Closed to Done in PR - Triage Group Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Make the Side Panel Fixed on the Tooling Page

5 participants