Conversation
|
Hi everyone, let me know if their is some need of improvement here. |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benjagm
left a comment
benjagm
left a comment
There was a problem hiding this comment.
Can you please review and fix the new borders added? They don't work in the dark theme.
DhairyaMajmudar
left a comment
DhairyaMajmudar
left a comment
There was a problem hiding this comment.
@cbum-dev pls. resolve the merge conflicts
Sure. |
|
Hi @cbum-dev Can you please leave the original border style? Current: Orginal: |
Do I have to remove the borders from light mode too ? @benjagm |
|
Hi @benjagm any update on this? |
benjagm
left a comment
benjagm
left a comment
There was a problem hiding this comment.
Looks mostly good. Just left some comments regarding using Image instead img.
pages/index.page.tsx
Outdated
| /> | ||
| </> | ||
| )} | ||
| <img |
There was a problem hiding this comment.
Can you use image instead of img?
There was a problem hiding this comment.
Hi @benjagm you mentioned only 2 places where I have to change the img tag or the whole page, as their are so many img tags present.
benjagm
left a comment
benjagm
left a comment
There was a problem hiding this comment.
Can you please replace img with Image in all cases? We prefer to use the next Image vs img from HTML.
pages/index.page.tsx
Outdated
| /> | ||
| </> | ||
| )} | ||
| <img |
Done @DhairyaMajmudar and @benjagm |
|
@cbum-dev it seems you need to add some padding in responsive mode, pls. check below screenshot
|
|
|
I have a problem with this PR. I don't think we are adding any relevant value, just another style that is not consistent at all with the other cards in the upper part of the section "Why JSON Schema?" I can accept the proposal of adding the improvements on the styles of the card, but if they are consistent across the landing page. I don't think the proposed single border improves the style of the cards on top in the section "Why JSON Schema?". Why not adding a hover style to "Why JSON Schema?" card and apply the same approach in the community cards? |
Now I think it's true as well. Making them consistent is a bonus.
I can think of another idea to make them consistent too, along with adding the hover effect you mentioned. |
|
Huge thanks for the hard work @cbum-dev . Closing this as discussed. |
github-project-automation
bot
moved this from Changes requested
to Done
in PR - Triage Group
3 participants
What kind of change does this PR introduce?
Ui fixes in main page particularly the "Welcome to the JSON Schema Community" section. Changed the styling and positioning of cards.
Changed more <img tags to Image.
Issue Number:
Screenshots/videos:
Screencast.From.2025-01-22.23-07-02.mp4
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?