[Fixed]: Navbar Active State Not Highlighting Docs and Specification related pages

[kajalmishra0829]

What kind of change does this PR introduce?

• Bugfix for Navbar Active State Not Highlighting Docs and Specification on related pages

Issue Number:

• 🐛 Bug: Navbar Active State Not Highlighting "Docs" and "Specification" on Related Pages #1535

Screenshots

If relevant, did you update the documentation?
N/A

Summary

• This PR fixes an issue where the navbar links for "Docs" and "Specification" were not highlighted as active when visiting related subpages.
• Previously, the isActive condition only checked if the router.asPath started with /docs or /specification, which did not account for related subpages like /overview/... or /draft/....
  Changes Made
• Updated the isActiveNav condition to include related subpaths:
  • Docs: Now considers /overview/... as part of the "Docs" section.
  • Specification: Now includes /draft/... as part of the "Specification" section.

Does this PR introduce a breaking change?
No

[github-actions]

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
website	✅ Ready (View Log)	Visit Preview	b5d2d7b

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72883db) to head (b5d2d7b).
Report is 35 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        18    +8     
  Lines          396       448   +52     
  Branches       106       116   +10     
=========================================
+ Hits           396       448   +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

[github-actions]

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

[kajalmishra0829]

@benjagm
please review this PR.

[cbum-dev]

Hi @KajalMishra-29 this issue was assigned to me. Please read the community guidelines.

[kajalmishra0829]

Hi @cbum-dev, I apologize for the confusion—I didn't realize the issue was assigned to you. I went ahead and resolved it, but if there's anything you'd like me to adjust or review, just let me know!

[DhairyaMajmudar]

LGTM 👍🏻

@KajalMishra-29 But pls. take care from next time to not to open PRs for already issues, Thanks!

[kajalmishra0829]

Thanks for the feedback, @DhairyaMajmudar! I’ll be more careful next time.

[cbum-dev]

LGTM 👍🏻

@KajalMishra-29 But pls. take care from next time to not to open PRs for already issues, Thanks!

Changes made by her dont actually do the full job. For doing that either we have to put here all the urls or put all the blogs in the same folder.
Personally I am doing the second approach because its much more alligned with nextjs.

[cbum-dev]

LGTM 👍🏻
@KajalMishra-29 But pls. take care from next time to not to open PRs for already issues, Thanks!

Changes made by her dont actually do the full job. For doing that either we have to put here all the urls or put all the blogs in the same folder. Personally I am doing the second approach because its much more alligned with nextjs.

What's your take in this @DhairyaMajmudar

[kajalmishra0829]

@cbum-dev I guess the approach you're suggesting would require modifying the code in multiple places. To avoid that, I opted for a shorter alternative by leveraging the fact that in the docs tab, inactive subpages always start from /overview, while in specification, inactive subpages start from /draft. I've also ensured that no other webpages follow this same pattern.

[github-actions]

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

[github-actions]

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

[benjagm]

Added some edge cases. Great work

[github-actions]

Congratulations, @KajalMishra-29 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!