Skip to content

fix: keep overview section open when user click on pro-help in docs#1539

Merged
benjagm merged 2 commits intojson-schema-org:mainfrom
Adi-204:pro-help-bug
Mar 17, 2025
Merged

fix: keep overview section open when user click on pro-help in docs#1539
benjagm merged 2 commits intojson-schema-org:mainfrom
Adi-204:pro-help-bug

Conversation

@Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Mar 17, 2025

What kind of change does this PR introduce?
Keep overview section open when user click on pro-help in docs.

Issue Number:

Screenshots/videos:
image

If relevant, did you update the documentation?
No

Summary
Keep overview section open when user click on pro-help in docs just like all other links in docs

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@Adi-204 Adi-204 requested a review from a team as a code owner March 17, 2025 08:42
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b68db4b) to head (1d0d068).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1539   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit cbe2993 into json-schema-org:main Mar 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Keep "Overview" Section Open When Clicking Links, Except "Pro Help"

2 participants