fix: Feedback Form Submits Empty String#1705
fix: Feedback Form Submits Empty String#1705chauhan-varun wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
===========================================
- Coverage 100.00% 99.12% -0.88%
===========================================
Files 10 18 +8
Lines 396 458 +62
Branches 106 118 +12
===========================================
+ Hits 396 454 +58
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @chauhan-varun Open source is not just about contributing code, it's also about collaboration, communication, and a bit of patience. I’m sure with time, you’ll make some meaningful contributions here. Looking forward to working together! |
|
Thank you so much for your kind message and guidance — I truly appreciate it. I completely understand the importance of following contribution guidelines and the need to coordinate properly within the team. The reason I went ahead with the PR was simply because the issue seemed very small and quick to resolve — it took me barely five minutes, and I thought it would be helpful to just get it done rather than wait to be assigned. That said, I totally respect the process and will make sure to get assigned to an issue first before submitting any future PRs. I'm really looking forward to learning and contributing more meaningfully to the project. Thanks again for the encouragement! |
|
@idanidan29 Can you please review this PR? |
idanidan29
left a comment
There was a problem hiding this comment.
@chauhan-varun Thanks for the effort your PR looks good! Just a quick note: in the current state of the website, the DocHelp component has already been adapted to ShadCN. Could you please rebase your branch and adjust the code accordingly to avoid conflicts?
|
@idanidan29 okay i'll adjust the changes |
What kind of change does this PR introduce?
Bug Fix: Fixed a bug that allowed blank feedback submissions by enforcing comment field validation
Issue Number:
Summary
The changes I made to fix the bug include:
These changes will prevent users from submitting empty feedback and will display an appropriate error message when they try to do so. The validation occurs both client-side (via the HTML5 required attribute) and server-side (via the JavaScript validation), providing a robust solution to the bug.
Does this PR introduce a breaking change?
N/A
If relevant, did you update the documentation?
N/A
Checklist
Please ensure the following tasks are completed before submitting this pull request.