Skip to content

Added social sharing buttons#1723

Open
cbum-dev wants to merge 3 commits intojson-schema-org:mainfrom
cbum-dev:1311
Open

Added social sharing buttons#1723
cbum-dev wants to merge 3 commits intojson-schema-org:mainfrom
cbum-dev:1311

Conversation

@cbum-dev
Copy link
Copy Markdown
Contributor

@cbum-dev cbum-dev commented Jun 18, 2025

What kind of change does this PR introduce?

Added social sharing buttons.

Issue Number:

Screenshots/videos:

image

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@cbum-dev cbum-dev requested a review from a team as a code owner June 18, 2025 15:22
@github-actions
Copy link
Copy Markdown

Hi @cbum-dev! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 18, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 8025304

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d585a99) to head (8025304).
⚠️ Report is 193 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          548       548           
  Branches       158       158           
=========================================
  Hits           548       548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github Utkarsh-123github moved this from Unclear to Ready to review in PR - Triage Group Jun 19, 2025
@benjagm benjagm moved this from Ready to review to Changes requested in PR - Triage Group Jun 28, 2025
Copy link
Copy Markdown
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. UX in laptop looks good but I think for mobile whe should add a line break to show share on X and share on Linkedin in different lines:

Screenshot 2025-06-28 at 15 45 12

Line 1: Share this article:
Line 2: Share on X
Line 3: Share on LinkedIn

@github-actions
Copy link
Copy Markdown

Hello! 👋

This pull request has been automatically marked as stale due to inactivity 😴

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific pull request has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this pull request forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience ❤️

@github-actions github-actions bot added the Status: Stale It's believed that this issue is no longer important to the requestor. label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Stale It's believed that this issue is no longer important to the requestor.

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Social Sharing Buttons

3 participants