Skip to content

fix: Special sidebar behaviour for pages without sidebar #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Utkarsh-123github
Copy link
Member

What kind of change does this PR introduce?
Through this PR, I have introduced a special sidebar behaviour for some pages that are not mentioned in the sidebar.

  • For https://json-schema.org/md-style-guide I have removed the sidebar as per our previous discussion.
  • For the release notes subsections I have marked the release notes item in the sidebar.

Issue Number:

Screenshots/videos:
Note: Please unmute the video for better understanding of the implementation.

2025-07-05.15-30-42.mp4

If relevant, did you update the documentation?
No

Summary
Fixes #1011

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@Utkarsh-123github Utkarsh-123github requested a review from a team as a code owner July 5, 2025 10:13
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jul 5, 2025
Copy link

github-actions bot commented Jul 5, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 118ad32

Copy link

codecov bot commented Jul 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a1ea8aa) to head (118ad32).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1760   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member Author

Utkarsh-123github commented Jul 5, 2025

Hi @benjagm , through this PR the main issue #1011 is resolved and is ready to reviewed and further merged. Kindly review at your convenience.

I have observed some of the issues related to Responsiveness and text visibility of the md-style-guide which were existing earlier too and was beyond the scope of the parent issue. So I have created a separate issue which will address it. #1759

Thank You!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@benjagm
Copy link
Collaborator

benjagm commented Aug 1, 2025

@Utkarsh-123github can you please fix the merge conflict?

@Utkarsh-123github
Copy link
Member Author

Hi @benjagm , I have updated the PR and it is now ready to be merged.
Thank you!

@Utkarsh-123github Utkarsh-123github moved this from Ready to review to Ready to Merge in PR - Triage Group Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Special sidebar behaviour for pages for pages without sidebar item
2 participants