fix: use unique stable keys for ToolingTable rows to improve reconcil… #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I’m closing this PR for now. For future contributions, please wait until the issue is assigned to you before opening a PR. We want to foster a collaborative environment, not a competitive one, and this helps avoid overlapping efforts. |
github-project-automation
bot
moved this from Ready to review
to Done
in PR - Triage Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix / Refactoring.
Issue Number:
Closes #2027
Summary
This PR fixes the "index as key" anti-pattern in the ToolingTable component. Using indices as keys causes React to incorrectly reuse component instances during filtering and sorting, leading to stale UI states and performance issues.
My solution implements a composite stable key using the tool's name and its source/homepage URL. I have applied this fix to both the Desktop and Mobile table views to ensure a consistent experience across all devices.