Skip to content

Conversation

@Dinkar30
Copy link

@Dinkar30 Dinkar30 commented Jan 4, 2026

This PR adds a Cypress component test to verify that a disabled Button does not invoke its onClick handler. While disabled styling was already covered, this makes the behavioral contract explicit and helps prevent regressions.

Checklist

@Dinkar30 Dinkar30 requested a review from a team as a code owner January 4, 2026 18:02
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jan 4, 2026
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Hi @Dinkar30! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 9925cbb

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Hi @Dinkar30! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (aa0a2ff) to head (9925cbb).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2065   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member

Hi @Dinkar30, could you please link the issue that this PR addresses? It looks like no issue has been referenced or tagged in the PR description.

@Dinkar30
Copy link
Author

Dinkar30 commented Jan 7, 2026

HI @Utkarsh-123github , thanks for checking. There isn’t an existing issue for this — this PR is a small test-only improvement identified while exploring the component test suite. Since it’s a scoped maintenance change (adding a missing behavioral assertion), I opened it directly without creating a separate issue.

If you’d prefer, I can open an issue and link it here.

@Utkarsh-123github
Copy link
Member

@Dinkar30, please ensure that you create an issue first and wait for it to go through the maintainer triage and assignment process. Once it’s assigned to you, you can go ahead and raise the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

2 participants