-
-
Notifications
You must be signed in to change notification settings - Fork 406
Add test to prevent click events on disabled Button #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @Dinkar30! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
Hi @Dinkar30! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Dinkar30, could you please link the issue that this PR addresses? It looks like no issue has been referenced or tagged in the PR description. |
|
HI @Utkarsh-123github , thanks for checking. There isn’t an existing issue for this — this PR is a small test-only improvement identified while exploring the component test suite. Since it’s a scoped maintenance change (adding a missing behavioral assertion), I opened it directly without creating a separate issue. If you’d prefer, I can open an issue and link it here. |
|
@Dinkar30, please ensure that you create an issue first and wait for it to go through the maintainer triage and assignment process. Once it’s assigned to you, you can go ahead and raise the PR. |
This PR adds a Cypress component test to verify that a disabled Button does not invoke its onClick handler. While disabled styling was already covered, this makes the behavioral contract explicit and helps prevent regressions.
Checklist