fix: Add target="_blank" and security attributes to footer external links #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sam-61s! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR improves user experience and security by ensuring that all external links in the footer open in a new browser tab instead of replacing the current page.
Opening external links in the same tab can unintentionally navigate users away from the site. This PR updates all footer external links to open in new tabs and adds appropriate security attributes to prevent potential security issues.
Issue Number:
Screenshots/videos:
Screen.Recording.2026-01-06.170325.mp4
If relevant, did you update the documentation?
N/A
Summary
This PR fixes a bug where external links in the footer (Open Collective, Slack, X, LinkedIn, YouTube, and GitHub) were opening in the same tab, causing users to navigate away from the JSON Schema website.
Changes:
target="_blank"to all footer external linksrel="noopener noreferrer"for improved security when opening links in new tabsDoes this PR introduce a breaking change?
No
Checklist