Conversation
the device JSON schema example merge 3 JSON into a single codeblock which break the syntax coloration and the example display
|
Hi @yne! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @yne! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hi @yne! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
the device JSON schema example merge 3 JSON into a single codeblock which break the syntax coloration and the example display
What kind of change does this PR introduce?
editorial fix on the example page
Issue Number:
Closes #2346
I just finished Reading the example on the website
Screenshots of the syntax issue:
Summary
The example page provide a "single merged" code block of 3 JSON when demonstrating the usage of $ref. this merged example is not a valid json. (at least not with the website syntax hilighting lib. This PR split the 3 files into 3 codeblocks
Does this PR introduce a breaking change?
Checklist
Please ensure the following tasks are completed before submitting this pull request.