Skip to content

Split JSON schema examples#2332

Open
yne wants to merge 1 commit intojson-schema-org:mainfrom
yne:patch-1
Open

Split JSON schema examples#2332
yne wants to merge 1 commit intojson-schema-org:mainfrom
yne:patch-1

Conversation

@yne
Copy link

@yne yne commented Mar 10, 2026

the device JSON schema example merge 3 JSON into a single codeblock which break the syntax coloration and the example display

What kind of change does this PR introduce?

editorial fix on the example page

Issue Number:

Closes #2346

I just finished Reading the example on the website

Screenshots of the syntax issue:

Screenshot_20260310-090202

Summary

The example page provide a "single merged" code block of 3 JSON when demonstrating the usage of $ref. this merged example is not a valid json. (at least not with the website syntax hilighting lib. This PR split the 3 files into 3 codeblocks

Does this PR introduce a breaking change?

Checklist

Please ensure the following tasks are completed before submitting this pull request.

the device JSON schema example merge 3 JSON into a single codeblock which break the syntax coloration and the example display
@yne yne requested a review from a team as a code owner March 10, 2026 08:05
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Mar 10, 2026
@github-actions
Copy link

Hi @yne! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 933e6fc

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (517455c) to head (933e6fc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          672       672           
  Branches       211       211           
=========================================
  Hits           672       672           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Hi @yne! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @yne! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

🐛 Bug: invalid example

1 participant