fix: clear error message when feedback form is closed#2348
Open
sakshammjn wants to merge 1 commit intojson-schema-org:mainfrom
Open
fix: clear error message when feedback form is closed#2348sakshammjn wants to merge 1 commit intojson-schema-org:mainfrom
sakshammjn wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 675 +3
Branches 211 211
=========================================
+ Hits 672 675 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Video:
screen.recording.for.issue.mov
If relevant, did you update the documentation?
Not applicable.
Summary
In the
DocsHelpcomponent, submitting the feedback form with an empty textarea shows a validation error. However, if the user closes the form by toggling the same Yes/No button, the form disappears but the error message remains floating on the page. This happens because thehandleVoteClicktoggle handler never resets the error state. This PR clears the error state when the form is closed and also when the user begins typing, ensuring a clean UI at all times.Does this PR introduce a breaking change?
No. The fix is minimal and only affects error state cleanup — existing validation behavior (error on empty/whitespace submission) is fully preserved.