Skip to content

fix: extract text from React elements in slugifyMarkdownHeadline to fix code-wrapped heading anchors #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Divyansh200102 wants to merge 1 commit into from
Closed

fix: extract text from React elements in slugifyMarkdownHeadline to fix code-wrapped heading anchors #2349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/slugifyMarkdownHeadline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import slugify from 'slugify';

function extractTextFromNode(node: any): string {
if (typeof node === 'string') return node;
if (Array.isArray(node)) return node.map(extractTextFromNode).join('');
if (node && typeof node === 'object' && node.props) {
return extractTextFromNode(node.props.children);
}
return '';
}

export default function slugifyMarkdownHeadline(
markdownChildren: string | any[],
): string {
Expand All @@ -16,11 +25,12 @@ export default function slugifyMarkdownHeadline(
return slug || null;
}, null);
if (metaSlug) return metaSlug;

const joinedChildren = markdownChildren
.filter((child) => typeof child === 'string')
.map((string) => string.replace(FRAGMENT_REGEX, ''))
.join(' ');
.map(extractTextFromNode)
.map((s) => s.replace(FRAGMENT_REGEX, ''))
.join(' ')
.trim();

const slug = slugify(joinedChildren, { lower: true, trim: true });
return slug;
}
Loading