Claude/fix active target mode 011 c uy l7 ny9 pfo gabvg1q lj w

[jsonify]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jsonify, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant new feature called 'Active Target Mode', which allows the auto-clicker to dynamically target the current mouse cursor position. This mode is toggled via a right-click, providing a more interactive and flexible way to use the application. Additionally, a new 'Click Test Window' has been added to aid in the visual verification and debugging of auto-clicking actions. These changes enhance both the user experience and the developer's ability to test the core functionality.

Highlights

• Active Target Mode: Introduced a new 'Active Target Mode' feature that allows the auto-clicker to follow the current cursor position. When enabled, a right-click will toggle the automation on or off at the cursor's location.
• Click Test Window: Added a dedicated 'Click Test Window' accessible from the Advanced tab. This window provides visual targets and real-time click counters to help users and developers validate auto-clicking functionality.
• Cursor Management: Implemented a new CursorManager service to handle custom cursor states, specifically displaying a crosshair cursor when 'Active Target Mode' is enabled and restoring the normal cursor otherwise. A timer ensures the custom cursor persists even with system interference.
• Hotkey and Mouse Event Monitoring: Enhanced HotkeyManager to include global and local monitoring for right-click mouse events, which are used to toggle automation in 'Active Target Mode'. Mouse events are debounced to prevent rapid-fire triggers.
• Settings and Configuration Updates: The ClickSettings model has been updated to include the isActiveTargetMode property, ensuring this setting is persisted, loaded, and exported correctly. The export version has been incremented to '1.2' to reflect these changes.
• Application Version Bump: The application's short version string in Info.plist has been updated from 1.5.3 to 1.5.5.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new "active target mode" feature, where clicks follow the cursor. The changes are comprehensive, including a new CursorManager for cursor visuals, updates to HotkeyManager for right-click detection, and significant logic adjustments in ClickItViewModel and ClickCoordinator to support this new mode. The implementation also includes a new test window and ensures settings are persisted with backward compatibility. My feedback focuses on improving maintainability and robustness by reducing code duplication and refining some implementation details.

[gemini-code-assist]

The implementation of unregisterMouseMonitor() is very similar to the existing unregisterGlobalHotkey() method. To reduce code duplication and improve maintainability, you could extract this common logic into a private helper function.

For example:

private func removeMonitors(global: inout Any?, local: inout Any?) {
    if let monitor = global {
        NSEvent.removeMonitor(monitor)
        global = nil
    }
    if let monitor = local {
        NSEvent.removeMonitor(monitor)
        local = nil
    }
}

func unregisterMouseMonitor() {
    removeMonitors(global: &globalMouseMonitor, local: &localMouseMonitor)
    print("HotkeyManager: Successfully unregistered mouse click monitoring")
}

You could then refactor unregisterGlobalHotkey() to use this helper as well.

[gemini-code-assist]

The timer closure should invalidate the timer itself when it's no longer needed. This prevents the timer from continuing to fire unnecessarily if isTargetCursorActive becomes false, making the implementation more robust and efficient.

                self.cursorUpdateTimer = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { [weak self] timer in
                    guard let self = self, self.isTargetCursorActive else {
                        timer.invalidate()
                        return
                    }
                    NSCursor.crosshair.set()
                }

[gemini-code-assist]

The functions restoreNormalCursor and forceRestoreNormalCursor contain a significant amount of duplicated code. You can refactor them to reduce this duplication, which will improve maintainability. forceRestoreNormalCursor can be implemented as a call to a more generic restoreNormalCursor function.

    /// Restores the normal system cursor
    func restoreNormalCursor(force: Bool = false) {
        DispatchQueue.main.async { [weak self] in
            guard let self = self else { return }

            if force || self.isTargetCursorActive {
                self.isTargetCursorActive = false

                // Stop the cursor update timer
                self.cursorUpdateTimer?.invalidate()
                self.cursorUpdateTimer = nil

                // Restore arrow cursor
                NSCursor.arrow.set()

                self.logger.info(force ? "Cursor forcefully restored" : "Normal cursor restored")
            }
        }
    }

    /// Force restore cursor (useful for cleanup on app termination)
    func forceRestoreNormalCursor() {
        restoreNormalCursor(force: true)
    }
}

[gemini-code-assist]

The logic for re-enabling the mouse monitor is duplicated in stopAutomation(), the clickCoordinator.$isActive sink (line 498), and emergencyStopAutomation() (line 615). To improve maintainability and reduce code duplication, you should extract this into a private helper method.

For example:

private func reEnableMouseMonitorIfNeeded() {
    if clickSettings.isActiveTargetMode {
        HotkeyManager.shared.registerMouseMonitor()
        print("ClickItViewModel: Re-enabled mouse monitoring after automation stopped.")
    }
}

You can then call reEnableMouseMonitorIfNeeded() in all three places.

[gemini-code-assist]

To improve code consistency and reduce duplication, you can use the existing setTargetPoint(_:) helper method, which correctly updates both targetPoint and clickSettings.clickLocation.

Suggested change

	targetPoint = currentMousePosition
	clickSettings.clickLocation = currentMousePosition
	self.setTargetPoint(currentMousePosition)