-
Notifications
You must be signed in to change notification settings - Fork 0
Update macOS deployment target to 14.0 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rkflows and build scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jsonify, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the macOS deployment target to an earlier version, specifically macOS 14.0. This change aims to improve compatibility, allowing the application to run on a broader range of macOS versions.
Highlights
- Deployment Target Update: The minimum macOS deployment target has been adjusted from
15.0to14.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to lower the macOS deployment target to 14.0. The change correctly updates the target for the SPM build path in build_app_unified.sh. However, my review identifies a critical inconsistency: the Xcode build path uses a separate Info.plist file that was not updated, which would result in different deployment targets depending on the build system used. I've also suggested an improvement to make the script more robust by respecting the MACOSX_DEPLOYMENT_TARGET environment variable for the SPM build, aligning it with the Xcode build's behavior for CI/CD environments.
build_app_unified.sh
Outdated
| <string>$BUILD_NUMBER</string> | ||
| <key>LSMinimumSystemVersion</key> | ||
| <string>15.0</string> | ||
| <string>14.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces two inconsistencies related to the macOS deployment target:
-
Xcode Build Mismatch: The Xcode build path uses
ClickIt/Info.plist(see line 68), which still specifies15.0as theLSMinimumSystemVersion. This means the app will have a different deployment target depending on whether it's built with SPM or Xcode. TheClickIt/Info.plistfile should also be updated to14.0to ensure consistent builds. -
Inconsistent CI/CD Behavior: The Xcode build path respects the
MACOSX_DEPLOYMENT_TARGETenvironment variable (lines 80-82), but this SPM build path hardcodes the value. This makes the script's behavior inconsistent across build systems, especially in CI/CD environments.
To make the script more robust, I suggest using the environment variable here as well, with a fallback to the new default. This ensures both build paths can be configured in the same way.
| <string>14.0</string> | |
| <string>${MACOSX_DEPLOYMENT_TARGET:-14.0}</string> |
…nd set macOS minimum version to 14.0
Adjust the macOS deployment target across CI/CD workflows and build scripts to ensure compatibility with earlier versions.