Replace local json-pointer implementation with @jsonjoy.com/json-pointer package #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-pointer package Co-authored-by: streamich <[email protected]>
Co-authored-by: streamich <[email protected]>
Copilot
AI
changed the title
[WIP] Remove
Replace local json-pointer implementation with @jsonjoy.com/json-pointer package
Aug 1, 2025
src/json-pointer/ folder. Install @jsonjoy.com/json-pointer package, and use the necessary types/code from there.
streamich
requested changes
Aug 1, 2025
| import {genShallowReader} from '../../msgpack/shallow-read'; | ||
| import {CborEncoder} from '../CborEncoder'; | ||
| import {CborDecoder} from '../CborDecoder'; | ||
| import {Path} from '../../json-pointer'; |
Contributor
Author
There was a problem hiding this comment.
Updated to use type import in commit 2a00fb5.
| import {CONST, ERROR, MAJOR} from './constants'; | ||
| import {CborDecoderBase} from './CborDecoderBase'; | ||
| import {JsonPackValue} from '../JsonPackValue'; | ||
| import type {Path} from '../json-pointer'; |
| import {genShallowReader} from '../shallow-read'; | ||
| import {MsgPackEncoder} from '../MsgPackEncoder'; | ||
| import {MsgPackDecoder} from '../MsgPackDecoder'; | ||
| import {Path} from '../../json-pointer'; |
Contributor
Author
There was a problem hiding this comment.
Updated to use type import in commit 2a00fb5.
| @@ -1,6 +1,6 @@ | |||
| import {JsonPackValue} from '.'; | |||
| import {MsgPackDecoderFast} from './MsgPackDecoderFast'; | |||
| import type {Path} from '../json-pointer'; | |||
| @@ -1,4 +1,4 @@ | |||
| import {Path} from '../json-pointer'; | |||
Contributor
Author
There was a problem hiding this comment.
Updated to use type import in commit 2a00fb5.
Co-authored-by: streamich <[email protected]>
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the local
src/json-pointer/folder and replaces it with the official@jsonjoy.com/json-pointerpackage to reduce code duplication and maintenance overhead.Changes Made
src/json-pointer/folder containing basic type definitions@jsonjoy.com/[email protected]as a dependencyWhy This Change?
The local json-pointer implementation only provided basic type definitions (
PathStepandPath), which are now available from the official@jsonjoy.com/json-pointerpackage. This package provides:Files Changed
src/cbor/CborDecoder.ts- Updated import statementsrc/cbor/__tests__/shallow-read.genShallowRead.spec.ts- Updated import statementsrc/msgpack/MsgPackDecoder.ts- Updated import statementsrc/msgpack/__tests__/shallow-read.genShallowRead.spec.ts- Updated import statementsrc/msgpack/shallow-read.ts- Updated import statementsrc/json-pointer/index.ts- Removedsrc/json-pointer/types.ts- RemovedVerification
PathandPathSteptypes work identically to the previous implementationThis change maintains full backward compatibility while reducing the codebase size and leveraging the official json-pointer implementation.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.