Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
295 changes: 295 additions & 0 deletions src/xdr/XdrEncoder.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,295 @@
import type {IWriter, IWriterGrowable} from '@jsonjoy.com/buffers/lib';
import type {BinaryJsonEncoder} from '../types';

/**
* XDR (External Data Representation) binary encoder for basic value encoding.
* Implements XDR binary encoding according to RFC 4506.
*
* Key XDR encoding principles:
* - All data types are aligned to 4-byte boundaries
* - Multi-byte quantities are transmitted in big-endian byte order
* - Strings and opaque data are padded to 4-byte boundaries
* - Variable-length arrays and strings are preceded by their length
*/
export class XdrEncoder implements BinaryJsonEncoder {
constructor(public readonly writer: IWriter & IWriterGrowable) {}

public encode(value: unknown): Uint8Array {
const writer = this.writer;
writer.reset();
this.writeAny(value);
return writer.flush();
}

/**
* Called when the encoder encounters a value that it does not know how to encode.
*/
public writeUnknown(value: unknown): void {
this.writeVoid();
}

public writeAny(value: unknown): void {
switch (typeof value) {
case 'boolean':
return this.writeBoolean(value);
case 'number':
return this.writeNumber(value);
case 'string':
return this.writeStr(value);
case 'object': {
if (value === null) return this.writeVoid();
const constructor = value.constructor;
switch (constructor) {
case Uint8Array:
return this.writeBin(value as Uint8Array);
default:
return this.writeUnknown(value);
}
}
case 'bigint':
return this.writeHyper(value);
case 'undefined':
return this.writeVoid();
default:
return this.writeUnknown(value);
}
}

/**
* Writes an XDR void value (no data is actually written).
*/
public writeVoid(): void {
// Void values are encoded as no data
}

/**
* Writes an XDR null value (for interface compatibility).
*/
public writeNull(): void {
this.writeVoid();
}

/**
* Writes an XDR boolean value as a 4-byte integer.
*/
public writeBoolean(bool: boolean): void {
this.writeInt(bool ? 1 : 0);
}

/**
* Writes an XDR signed 32-bit integer in big-endian format.
*/
public writeInt(int: number): void {
const writer = this.writer;
writer.ensureCapacity(4);
writer.view.setInt32(writer.x, Math.trunc(int), false); // big-endian
writer.move(4);
}

/**
* Writes an XDR unsigned 32-bit integer in big-endian format.
*/
public writeUnsignedInt(uint: number): void {
const writer = this.writer;
writer.ensureCapacity(4);
writer.view.setUint32(writer.x, Math.trunc(uint) >>> 0, false); // big-endian
writer.move(4);
}

/**
* Writes an XDR signed 64-bit integer (hyper) in big-endian format.
*/
public writeHyper(hyper: number | bigint): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use DataView.prototype.setBigInt64() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use DataView.prototype.setBigInt64() for cleaner bigint encoding (d10904e)

const writer = this.writer;
writer.ensureCapacity(8);

if (typeof hyper === 'bigint') {
// Convert bigint to two 32-bit values for big-endian encoding
const high = Number((hyper >> BigInt(32)) & BigInt(0xffffffff));
const low = Number(hyper & BigInt(0xffffffff));
writer.view.setInt32(writer.x, high, false); // high 32 bits
writer.view.setUint32(writer.x + 4, low, false); // low 32 bits
} else {
const truncated = Math.trunc(hyper);
const high = Math.floor(truncated / 0x100000000);
const low = truncated >>> 0;
writer.view.setInt32(writer.x, high, false); // high 32 bits
writer.view.setUint32(writer.x + 4, low, false); // low 32 bits
}
writer.move(8);
}

/**
* Writes an XDR unsigned 64-bit integer (unsigned hyper) in big-endian format.
*/
public writeUnsignedHyper(uhyper: number | bigint): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use DataView.prototype.setBigUint64() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use DataView.prototype.setBigUint64() for cleaner unsigned bigint encoding (d10904e)

const writer = this.writer;
writer.ensureCapacity(8);

if (typeof uhyper === 'bigint') {
// Convert bigint to two 32-bit values for big-endian encoding
const high = Number((uhyper >> BigInt(32)) & BigInt(0xffffffff));
const low = Number(uhyper & BigInt(0xffffffff));
writer.view.setUint32(writer.x, high, false); // high 32 bits
writer.view.setUint32(writer.x + 4, low, false); // low 32 bits
} else {
const truncated = Math.trunc(Math.abs(uhyper));
const high = Math.floor(truncated / 0x100000000);
const low = truncated >>> 0;
writer.view.setUint32(writer.x, high, false); // high 32 bits
writer.view.setUint32(writer.x + 4, low, false); // low 32 bits
}
writer.move(8);
}

/**
* Writes an XDR float value using IEEE 754 single-precision in big-endian format.
*/
public writeFloat(float: number): void {
const writer = this.writer;
writer.ensureCapacity(4);
writer.view.setFloat32(writer.x, float, false); // big-endian
writer.move(4);
}

/**
* Writes an XDR double value using IEEE 754 double-precision in big-endian format.
*/
public writeDouble(double: number): void {
const writer = this.writer;
writer.ensureCapacity(8);
writer.view.setFloat64(writer.x, double, false); // big-endian
writer.move(8);
}

/**
* Writes an XDR quadruple value (128-bit float).
* Note: JavaScript doesn't have native 128-bit float support.
*/
public writeQuadruple(quad: number): void {
throw new Error('not implemented');
}

/**
* Writes XDR opaque data with fixed length.
* Data is padded to 4-byte boundary.
*/
public writeOpaque(data: Uint8Array, size: number): void {
if (data.length !== size) {
throw new Error(`Opaque data length ${data.length} does not match expected size ${size}`);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this check and size property.

Suggested change
public writeOpaque(data: Uint8Array, size: number): void {
if (data.length !== size) {
throw new Error(`Opaque data length ${data.length} does not match expected size ${size}`);
}
public writeOpaque(data: Uint8Array): void {
const size = data.length;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed size check and parameter from writeOpaque() - now takes only data with automatic length detection (d10904e)


const writer = this.writer;
const paddedSize = Math.ceil(size / 4) * 4;
writer.ensureCapacity(paddedSize);

// Write data
writer.buf(data, size);

// Write padding bytes
const padding = paddedSize - size;
for (let i = 0; i < padding; i++) {
writer.u8(0);
}
}

/**
* Writes XDR variable-length opaque data.
* Length is written first, followed by data padded to 4-byte boundary.
*/
public writeVarlenOpaque(data: Uint8Array): void {
this.writeUnsignedInt(data.length);

const writer = this.writer;
const paddedSize = Math.ceil(data.length / 4) * 4;
writer.ensureCapacity(paddedSize);

// Write data
writer.buf(data, data.length);

// Write padding bytes
const padding = paddedSize - data.length;
for (let i = 0; i < padding; i++) {
writer.u8(0);
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse .writeOpaque() here if possible:

Suggested change
const writer = this.writer;
const paddedSize = Math.ceil(data.length / 4) * 4;
writer.ensureCapacity(paddedSize);
// Write data
writer.buf(data, data.length);
// Write padding bytes
const padding = paddedSize - data.length;
for (let i = 0; i < padding; i++) {
writer.u8(0);
}
}
this.writeOpaque(data);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified writeVarlenOpaque() to reuse writeOpaque() method (d10904e)


/**
* Writes an XDR string with UTF-8 encoding.
* Length is written first, followed by UTF-8 bytes padded to 4-byte boundary.
*/
public writeStr(str: string): void {
const writer = this.writer;

// Write string using writer's UTF-8 method and get actual byte count
const lengthOffset = writer.x;
writer.x += 4; // Reserve space for length
const bytesWritten = writer.utf8(str);

// Calculate and write padding
const paddedSize = Math.ceil(bytesWritten / 4) * 4;
const padding = paddedSize - bytesWritten;
for (let i = 0; i < padding; i++) {
writer.u8(0);
}

// Go back and write the actual byte length
const currentPos = writer.x;
writer.x = lengthOffset;
this.writeUnsignedInt(bytesWritten);
writer.x = currentPos;
}

public writeArr(arr: unknown[]): void {
throw new Error('writeArr not implemented in XDR encoder');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error('writeArr not implemented in XDR encoder');
throw new Error('not implemented');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed error message to be consistent: 'not implemented' (d10904e)

}

public writeObj(obj: Record<string, unknown>): void {
throw new Error('writeObj not implemented in XDR encoder');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error('writeObj not implemented in XDR encoder');
throw new Error('not implemented');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed error message to be consistent: 'not implemented' (d10904e)

}

// BinaryJsonEncoder interface methods

/**
* Generic number writing - determines type based on value
*/
public writeNumber(num: number): void {
if (Number.isInteger(num)) {
if (num >= -2147483648 && num <= 2147483647) {
this.writeInt(num);
} else {
this.writeHyper(num);
}
} else {
this.writeDouble(num);
}
}

/**
* Writes an integer value
*/
public writeInteger(int: number): void {
this.writeInt(int);
}

/**
* Writes an unsigned integer value
*/
public writeUInteger(uint: number): void {
this.writeUnsignedInt(uint);
}

/**
* Writes binary data
*/
public writeBin(buf: Uint8Array): void {
this.writeVarlenOpaque(buf);
}

/**
* Writes an ASCII string (same as regular string in XDR)
*/
public writeAsciiStr(str: string): void {
this.writeStr(str);
}
}
Loading