Add codesniffer; fix phpcs errors wrt PSR12 #660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raising to PHP 7.1 should be okay (as per #706 (comment)). However I think it is unexpected to have this "big" change be part of (what looks like) a housekeeping PR. @robocoder I had tagged you in #659 as well which is now closed by you without a comment. Can we make the assumption you're no longer pursuing any PR's on this project? Meaning #660 and #661 should also be closed? |
|
Yeah, that's to be expected when PRs collect dust for 3 yrs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assumes you bump the PHP requirement to PHP 7.1+.