Fix #827

[DannyvdSluijs]

This PR will:

• Scan schemas that are being added for id properties and register them if valid schemas
• Avoid altering the id for sibling ref properties
• Don't register schema or expand refs when found in enum or const

This will fix #827

[Copilot]

Pull Request Overview

This PR addresses issue #827 by enhancing schema scanning and preventing unintended alterations to sibling ref properties. Key changes include:

• Updating function signatures with strict type hints and return types in both SchemaStorageInterface and SchemaStorage.
• Switching to strict equality (===) for schema id comparisons.
• Adding a recursive subschema registration method in SchemaStorage to scan for nested id properties.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/JsonSchema/SchemaStorageInterface.php	Updated function signatures with type hints and return types.
src/JsonSchema/SchemaStorage.php	Enhanced addSchema and expandRefs methods for better reference resolution and introduced subschema registration.
phpstan-baseline.neon	Adjusted baseline messages to reflect type validations and return type updates.
CHANGELOG.md	Updated changelog with new issue fix information.

Comments suppressed due to low confidence (1)

src/JsonSchema/SchemaStorage.php:105

• [nitpick] The variable names '$parentId' and '$childId' are used to manage schema reference resolution; adding a brief comment or using more descriptive names may improve clarity for future maintainers.

            if (property_exists($schema, 'id') && is_string($schema->id) && $childId !== $schema->id) {

[ZivHuang3788]

Hello DannyvdSluijs,

I encountered the error message Could not resolve fragment '#/definitions/enum': no file is defined while using http://swagger.io/v2/schema.json as the validation basis. I discovered that this issue started appearing in versions after 6.4.2. It seems to have originated from the changes made in a85ac59. Could you please advise me on how to avoid this issue?

Thank you!