don't test external early-access in unit tests (github#26612)

* don't test external early-access in unit tests

* make the rendering tests less weird && gg push

Author: peterbe

middleware/contextualizers/early-access-links.js

@@ -1,7 +1,7 @@
 import { uniq } from 'lodash-es'
 
 export default function earlyAccessContext(req, res, next) {
-  if (process.env.NODE_ENV === 'production') {
+  if (process.env.NODE_ENV !== 'development') {
     return next(404)
   }
 

tests/rendering/server.js

@@ -596,46 +596,33 @@ describe('server', () => {
   })
 
   describeViaActionsOnly('Early Access articles', () => {
-    let hiddenPageHrefs, hiddenPages
-
-    beforeAll(async () => {
-      const $ = await getDOM('/early-access')
-      hiddenPageHrefs = $('#article-contents ul > li > a')
-        .map((i, el) => $(el).attr('href'))
-        .get()
-
-      const allPages = await loadPages()
-      hiddenPages = allPages.filter((page) => page.languageCode === 'en' && page.hidden)
-    })
-
-    test('exist in the set of English pages', async () => {
-      expect(hiddenPages.length).toBeGreaterThan(0)
-    })
-
-    test('are listed at /early-access', async () => {
-      expect(hiddenPageHrefs.length).toBeGreaterThan(0)
-    })
-
     // Test skipped because this test file is no longer able to
     // change the `NODE_ENV` between tests because it depends on
     // HTTP and not raw supertest.
     // Idea: Move this one test somewhere into tests/unit/
     test.skip('are not listed at /early-access in production', async () => {
-      const oldNodeEnv = process.env.NODE_ENV
-      process.env.NODE_ENV = 'production'
       const res = await get('/early-access', { followRedirects: true })
-      process.env.NODE_ENV = oldNodeEnv
       expect(res.statusCode).toBe(404)
     })
 
     test('have noindex meta tags', async () => {
-      const $ = await getDOM(hiddenPageHrefs[0])
-      expect($('meta[content="noindex"]').length).toBe(1)
-    })
-
-    test('public articles do not have noindex meta tags', async () => {
-      const $ = await getDOM('/en/articles/set-up-git')
-      expect($('meta[content="noindex"]').length).toBe(0)
+      const allPages = await loadPages()
+      // This is what the earlyAccessContext middleware does to get a
+      // list of early-access pages for that TOC it displays when
+      // viewing /en/early-access in development.
+      // Here we're using it to get a least 1 page we can end-to-end
+      // test to look at it's meta tags.
+      const hiddenPages = allPages.filter(
+        (page) =>
+          page.languageCode === 'en' &&
+          page.hidden &&
+          page.relativePath.startsWith('early-access') &&
+          !page.relativePath.endsWith('index.md')
+      )
+      for (const { href } of hiddenPages[0].permalinks) {
+        const $ = await getDOM(href)
+        expect($('meta[content="noindex"]').length).toBe(1)
+      }
     })
   })
 

tests/unit/early-access.js

@@ -1,11 +1,10 @@
-import { jest } from '@jest/globals'
 import { stat } from 'fs/promises'
 import path from 'path'
-import { testViaActionsOnly } from '../helpers/conditional-runs.js'
-import { getDOM } from '../helpers/supertest.js'
-import got from 'got'
 
-jest.useFakeTimers('legacy')
+import { expect } from '@jest/globals'
+
+import { testViaActionsOnly } from '../helpers/conditional-runs.js'
+import { get, getDOM } from '../helpers/e2etest.js'
 
 describe('cloning early-access', () => {
   testViaActionsOnly('the content directory exists', async () => {
@@ -25,21 +24,9 @@ describe('cloning early-access', () => {
 })
 
 describe('rendering early-access', () => {
-  jest.setTimeout(5 * 60 * 1000)
-
-  testViaActionsOnly('the top-level TOC renders locally', async () => {
-    const $ = await getDOM('/en/early-access')
-    expect(
-      $.html().includes('Hello, local developer! This page is not visible on production.')
-    ).toBe(true)
-    expect($('ul a').length).toBeGreaterThan(5)
-  })
-
-  testViaActionsOnly('the top-level TOC does not render on production', async () => {
-    async function getEarlyAccess() {
-      return await got('https://docs.github.com/en/early-access')
-    }
-    await expect(getEarlyAccess).rejects.toThrowError('Response code 404 (Not Found)')
+  testViaActionsOnly('the top-level TOC is always 404', async () => {
+    const res = await get('/en/early-access')
+    expect(res.statusCode).toBe(404)
   })
 
   testViaActionsOnly('TOCs display on category pages', async () => {