Skip to content

Commit 5cfbf85

Browse files
authored
Update dependencies (#430)
* upgrade dependencies in range * upgrade joi closes #424 * upgrade code closes #425 * upgrade hoek closes #426 * upgrade boom closes #427 * upgrade catbox #428 * switch to marky-markdown * upgrade sinon closes #417 #419 * fix test by ignoring another global, document globals * keep upgrading 📈 * keep up w/ joi ref #424 😓
1 parent e127178 commit 5cfbf85

File tree

9 files changed

+1527
-422
lines changed

9 files changed

+1527
-422
lines changed

.snyk

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
version: v1.5.0
22
ignore: {}
3-
patch:
4-
'npm:marked:20150520':
5-
- marked:
6-
patched: '2016-07-25T01:12:09.411Z'
3+
patch: {}

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ In one terminal, have jsPerf running (`npm start`). In another, have webdriver-m
4444
SELENIUM_SERVER=http://127.0.0.1:4444/wd/hub npm run test-e2e
4545
```
4646

47+
### Known Globals
48+
49+
Lab detects global variable leaks. Sometimes downstream dependencies make this unavoidable so we ignore specific variables in the `lab` command for `npm test` (`package.json#scripts.test`). Here are the known globals with explanations:
50+
51+
- `__core-js_shared__` stems from `core-js`?
52+
- `__grim__` stems from `grim`, a dependency of `marky-markdown` (`npm ls grim`)
53+
4754
## Adding new dependencies
4855

4956
Install using `npm` and either `--save` or `--save-dev`. **Do not edit `package.json` manually.**

config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const envSchema = Joi.object().keys({
3737
const result = Joi.validate(process.env, envSchema);
3838

3939
if (result.error) {
40-
throw new Error(`${result.error.details[0].path} environment variable is missing`);
40+
throw new Error(`${result.error.details[0].path[0]} environment variable is missing`);
4141
}
4242

4343
var Confidence = require('confidence');

0 commit comments

Comments
 (0)