parameter type mismatch checking + improvements to ParameterType.SELECT
#3557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 761ae37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
one thing that crossed my mind recently while reviewing this: would this constitute as a breaking change? seeing as though there might be certain fields (such as the ones in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trials will now properly check if non-array parameters given are of the same type, throwing an error if not in order to give more helpful error message as opposed to some variation of some method being called on a mismatched type not existing. along with this,
ParameterType.SELECTnow properly checks if the value given is in theoptionsfield; plugin developers may now specify certain possible parameter values for a parameter removing the need for manual parameter input validation.this PR depends on #3556, as the
video-*-responseplugins have a parameter type mismatch with their default values, causing their respective tests to fail.