[Tests] improve coverage

Author: ljharb

__tests__/src/rules/aria-role-test.js

@@ -24,10 +24,12 @@ const errorMessage = {
   type: 'JSXAttribute',
 };
 
-const validRoles = [...roles.keys()].filter(
+const roleKeys = [...roles.keys()];
+
+const validRoles = roleKeys.filter(
   role => roles.get(role).abstract === false,
 );
-const invalidRoles = [...roles.keys()].filter(
+const invalidRoles = roleKeys.filter(
   role => roles.get(role).abstract === true,
 );
 
@@ -60,6 +62,8 @@ ruleTester.run('aria-role', rule, {
     { code: '<div role="doc-appendix doc-bibliography" />' },
     { code: '<Bar baz />' },
     { code: '<Foo role="bar" />', options: ignoreNonDOMSchema },
+    { code: '<fakeDOM role="bar" />', options: ignoreNonDOMSchema },
+    { code: '<img role="presentation" />', options: ignoreNonDOMSchema },
   ].concat(validTests).map(parserOptionsMapper),
 
   invalid: [

__tests__/src/rules/aria-unsupported-elements-test.js

@@ -44,6 +44,9 @@ const ariaValidityTests = domElements.map((element) => {
   return {
     code: `<${element} ${aria} />`,
   };
+}).concat({
+  code: '<fake aria-hidden />',
+  errors: [errorMessage('aria-hidden')],
 });
 
 // Generate invalid test cases.
@@ -57,7 +60,7 @@ const invalidRoleValidityTests = domElements
 const invalidAriaValidityTests = domElements
   .filter(element => Boolean(dom.get(element).reserved))
   .map(reservedElem => ({
-    code: `<${reservedElem} aria-hidden {...props} />`,
+    code: `<${reservedElem} aria-hidden aria-role="none" {...props} />`,
     errors: [errorMessage('aria-hidden')],
   }));
 

__tests__/src/rules/no-autofocus-test.js

@@ -36,6 +36,7 @@ ruleTester.run('no-autofocus', rule, {
     { code: '<input autofocus="true" />;' },
     { code: '<Foo bar />' },
     { code: '<Foo autoFocus />', options: ignoreNonDOMSchema },
+    { code: '<div><div autofocus /></div>', options: ignoreNonDOMSchema },
   ].map(parserOptionsMapper),
   invalid: [
     { code: '<div autoFocus />', errors: [expectedError] },

__tests__/src/rules/no-interactive-element-to-noninteractive-role-test.js

@@ -368,6 +368,7 @@ ruleTester.run(`${ruleName}:recommended`, rule, {
   valid: [
     ...alwaysValid,
     { code: '<tr role="presentation" />;' },
+    { code: '<Component role="presentation" />;' },
   ]
     .map(ruleOptionsMapperFactory(recommendedOptions))
     .map(parserOptionsMapper),

__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js

@@ -447,6 +447,7 @@ ruleTester.run(`${ruleName}:recommended`, rule, {
     { code: '<li role="menuitem" />;' },
     { code: '<li role="row" />;' },
     { code: '<li role="treeitem" />;' },
+    { code: '<Component role="treeitem" />;' },
   ]
     .map(ruleOptionsMapperFactory(recommendedOptions))
     .map(parserOptionsMapper),

__tests__/src/util/attributesComparator-test.js

@@ -2,6 +2,7 @@
 import expect from 'expect';
 import attributesComparator from '../../../src/util/attributesComparator';
 import JSXAttributeMock from '../../../__mocks__/JSXAttributeMock';
+import JSXElementMock from '../../../__mocks__/JSXElementMock';
 
 describe('attributesComparator', () => {
   describe('base attributes', () => {
@@ -65,6 +66,7 @@ describe('attributesComparator', () => {
           describe('and the values are the different', () => {
             it('should return false', () => {
               attributes = [
+                JSXElementMock(),
                 JSXAttributeMock('biz', 2),
                 JSXAttributeMock('ziff', 'opo'),
                 JSXAttributeMock('far', 'lolz'),

__tests__/src/util/implicitRoles/input-test.js

@@ -0,0 +1,32 @@
+/* eslint-env mocha */
+import expect from 'expect';
+import JSXAttributeMock from '../../../../__mocks__/JSXAttributeMock';
+import getImplicitRoleForInput from '../../../../src/util/implicitRoles/input';
+
+describe('isAbstractRole', () => {
+  it('works for buttons', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'button')])).toBe('button');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'image')])).toBe('button');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'reset')])).toBe('button');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'submit')])).toBe('button');
+  });
+  it('works for checkboxes', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'checkbox')])).toBe('checkbox');
+  });
+  it('works for radios', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'radio')])).toBe('radio');
+  });
+  it('works for ranges', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'range')])).toBe('slider');
+  });
+  it('works for textboxes', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'email')])).toBe('textbox');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'password')])).toBe('textbox');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'search')])).toBe('textbox');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'tel')])).toBe('textbox');
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', 'url')])).toBe('textbox');
+  });
+  it('works for the default case', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', '')])).toBe('textbox');
+  });
+});

__tests__/src/util/implicitRoles/menu-test.js

@@ -0,0 +1,13 @@
+/* eslint-env mocha */
+import expect from 'expect';
+import JSXAttributeMock from '../../../../__mocks__/JSXAttributeMock';
+import getImplicitRoleForMenu from '../../../../src/util/implicitRoles/menu';
+
+describe('isAbstractRole', () => {
+  it('works for toolbars', () => {
+    expect(getImplicitRoleForMenu([JSXAttributeMock('type', 'toolbar')])).toBe('toolbar');
+  });
+  it('works for non-toolbars', () => {
+    expect(getImplicitRoleForMenu([JSXAttributeMock('type', '')])).toBe('');
+  });
+});

__tests__/src/util/implicitRoles/menuitem-test.js

@@ -0,0 +1,19 @@
+/* eslint-env mocha */
+import expect from 'expect';
+import JSXAttributeMock from '../../../../__mocks__/JSXAttributeMock';
+import getImplicitRoleForMenuitem from '../../../../src/util/implicitRoles/menuitem';
+
+describe('isAbstractRole', () => {
+  it('works for menu items', () => {
+    expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', 'command')])).toBe('menuitem');
+  });
+  it('works for menu item checkboxes', () => {
+    expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', 'checkbox')])).toBe('menuitemcheckbox');
+  });
+  it('works for menu item radios', () => {
+    expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', 'radio')])).toBe('menuitemradio');
+  });
+  it('works for non-toolbars', () => {
+    expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', '')])).toBe('');
+  });
+});

__tests__/src/util/schemas-test.js

@@ -1,6 +1,6 @@
 /* eslint-env jest */
 import assert from 'assert';
-import { generateObjSchema, arraySchema } from '../../../src/util/schemas';
+import { generateObjSchema, arraySchema, enumArraySchema } from '../../../src/util/schemas';
 
 describe('schemas', () => {
   it('should generate an object schema with correct properties', () => {
@@ -13,4 +13,18 @@ describe('schemas', () => {
     assert.deepEqual(properties.foo, 'bar');
     assert.deepEqual(properties.baz.type, 'array');
   });
+  describe('enumArraySchema', () => {
+    it('works with no arguments', () => {
+      assert.deepEqual(enumArraySchema(), {
+        additionalItems: false,
+        items: {
+          enum: [],
+          type: 'string',
+        },
+        minItems: 0,
+        type: 'array',
+        uniqueItems: true,
+      });
+    });
+  });
 });