Merge pull request #439 from ljharb/fix_label_has_for_nesting

[Fix] `label-has-for`: fix issue with improper nesting validation

Author: jessebeach

__tests__/src/rules/label-has-for-test.js

@@ -165,5 +165,15 @@ ruleTester.run('label-has-for', rule, {
     { code: '<label>First Name</label>', errors: [expectedSomeError], options: optionsRequiredSome },
     { code: '<label>{children}</label>', errors: [expectedSomeError], options: optionsRequiredSome },
     { code: '<label>{children}</label>', errors: [expectedNestingError], options: optionsRequiredNesting },
+    {
+      code: '<form><input type="text" id="howmuch" value="1" /><label htmlFor="howmuch">How much ?</label></form>',
+      errors: [expectedEveryError],
+      options: optionsRequiredEvery,
+    },
+    {
+      code: '<form><input type="text" id="howmuch" value="1" /><label htmlFor="howmuch">How much ?<span /></label></form>',
+      errors: [expectedEveryError],
+      options: optionsRequiredEvery,
+    },
   ].map(parserOptionsMapper),
 });

src/rules/label-has-for.js

@@ -27,7 +27,10 @@ const schema = {
   },
 };
 
-const validateNesting = node => node.parent.children.some(child => child.type === 'JSXElement');
+const validateNesting = node => node.parent.children.some((child) => {
+  const opener = child.openingElement;
+  return child.type === 'JSXElement' && opener && opener.name.name === 'input';
+});
 
 const validateId = (node) => {
   const htmlForAttr = getProp(node.attributes, 'htmlFor');