[Fix] disallow extra properties in rule options

__tests__/src/rules/label-has-for-test.js

@@ -96,7 +96,7 @@ ruleTester.run('label-has-for', rule, {
     { code: '<label><input /></label>', options: optionsRequiredNesting },
     { code: '<label htmlFor="input"><input /></label>', options: optionsRequiredEvery },
     { code: '<label><input /></label>', options: optionsChildrenAllowed },
-    { code: '<Descriptor htmlFor="foo">Test!</Descriptor>', options: [assign({}, optionsComponents, optionsChildrenAllowed)] },
+    { code: '<Descriptor htmlFor="foo">Test!</Descriptor>', options: [assign({}, optionsComponents[0], optionsChildrenAllowed[0])] },
     { code: '<label>Test!</label>', options: optionsChildrenAllowed },
     { code: '<label htmlFor="foo">Test!</label>', options: optionsChildrenAllowed },
     { code: '<label>{children}</label>', options: optionsChildrenAllowed },

src/index.js

@@ -81,7 +81,6 @@ const recommendedRules = {
         'tree',
         'treegrid',
       ],
-      includeRoles: ['alert', 'dialog'],
     },
   ],
   'jsx-a11y/heading-has-content': 'error',
@@ -235,7 +234,6 @@ const strictRules = {
         'tree',
         'treegrid',
       ],
-      includeRoles: ['alert', 'dialog'],
     },
   ],
   'jsx-a11y/heading-has-content': 'error',

src/rules/label-has-for.js

@@ -26,6 +26,7 @@ const schema = {
     },
     allowChildren: { type: 'boolean' },
   },
+  additionalProperties: false,
 };
 // Breadth-first search, assuming that HTML for forms is shallow.
 function validateNesting(node) {

src/rules/no-noninteractive-element-interactions.js

@@ -48,7 +48,16 @@ export default ({
       url: 'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-noninteractive-element-interactions.md',
       description: 'Non-interactive elements should not be assigned mouse or keyboard event listeners.',
     },
-    schema: [schema],
+    schema: [{
+      ...schema,
+      additionalProperties: {
+        type: 'array',
+        items: {
+          type: 'string',
+        },
+        uniqueItems: true,
+      },
+    }],
   },
 
   create: (context: ESLintContext): ESLintVisitorSelectorConfig => {

src/rules/no-noninteractive-tabindex.js

@@ -34,6 +34,9 @@ const schema = generateObjSchema({
     ...arraySchema,
     description: 'An array of HTML tag names',
   },
+  allowExpressionValues: {
+    type: 'boolean',
+  },
 });
 
 export default ({

src/rules/no-static-element-interactions.js

@@ -37,6 +37,9 @@ const defaultInteractiveProps = [].concat(
 );
 const schema = generateObjSchema({
   handlers: arraySchema,
+  allowExpressionValues: {
+    type: 'boolean',
+  },
 });
 
 export default ({

src/util/schemas.js

@@ -30,4 +30,5 @@ export const generateObjSchema = (properties = {}, required = undefined) => ({
   type: 'object',
   properties,
   required,
+  additionalProperties: false,
 });