bug: fix summary being treated as non-interactive

[khiga8]

Fixes: #656

This ensures that summary is treated as an interactive element so it doesn't raise a false positive with the no-static-element-interactions lint rule.

[khiga8]

I am going to test bumping axobject-query to the latest 4.0.0 since that might resolve this bug.

If bumping this package should be done with more care/breaks things, then I may instead suggest a hard-coded update to src/util/isInteractiveElement.js to immediately resolve this bug.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (882bd4d) to head (07d3353).

❗ Current head 07d3353 differs from pull request most recent head 89301a8

Please upload reports for the commit 89301a8 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   99.03%   99.02%   -0.01%     
==========================================
  Files         107      105       -2     
  Lines        1651     1638      -13     
  Branches      581      581              
==========================================
- Hits         1635     1622      -13     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aarfing]

Good job. Was hoping a fix was one the way for this issue :)

[ljharb]

rebased, but it's failing.

[khiga8]

@ljharb I see the new failures are related to commit 6a048da.

Is this needed?

[ljharb]

@khiga8 we're stuck on an older version of aria-query and axobject-query, which don't have "summary" in the right place, so i think it is still needed.

[jessebeach]

@ljharb I'm the blocker here. Would you like permission to publish updates for aria-query and axobject-query? I'd like to remove myself from the dependency chain here so folks are unblocked. I'm flat out with work-work and family lately and I don't have the bandwidth to jump in here.

[ljharb]

@jessebeach i'd be more than happy to help maintain those projects! I'd still want you to weigh in on the dequal breaking change stuff tho, which is the blocker for us upgrading.

[jessebeach]

i'd be more than happy to help maintain those projects

You're a maintainer now. That's one hurdle =D

[ljharb]

@jessebeach thanks! do i need npm ownership as well?

[jessebeach]

@jessebeach thanks! do i need npm ownership as well?

I invited you to both NPM projects. That's 2 hurdles =D

[ljharb]

I've rebased this onto main, which has unpinned axobject-query, but aria-query still needs a release for us to be able to unpin it, and presumably at that point this PR will pass tests.