Merge pull request #119 from rpl/fix/displayName-and-propTypes-on-jsx-false

Fix detection of missing displayName and propTypes when ecmaFeatures.jsx is false

Author: yannickcr

lib/rules/display-name.js

@@ -117,6 +117,12 @@ module.exports = function(context) {
         }
         markDisplayNameAsDeclared(node);
       });
+
+      if (componentUtil.isComponentDefinition(node)) {
+        componentList.set(context, node, {
+          isReactComponent: true
+        });
+      }
     },
 
     'Program:exit': function() {

lib/rules/prop-types.js

@@ -509,6 +509,12 @@ module.exports = function(context) {
         }
         markPropTypesAsDeclared(node, property.value);
       });
+
+      if (componentUtil.isComponentDefinition(node)) {
+        componentList.set(context, node, {
+          isReactComponent: true
+        });
+      }
     },
 
     'Program:exit': function() {

tests/lib/rules/display-name.js

@@ -89,6 +89,20 @@ eslintTester.addRuleTest('lib/rules/display-name', {
   }],
 
   invalid: [{
+    code: [
+      'var Hello = React.createClass({',
+      '  render: function() {',
+      '    return React.createElement("div", {}, "text content");',
+      '  }',
+      '});'
+    ].join('\n'),
+    ecmaFeatures: {
+      jsx: false
+    },
+    errors: [{
+      message: 'Component definition is missing display name'
+    }]
+  }, {
     code: [
       'var Hello = React.createClass({',
       '  render: function() {',

tests/lib/rules/prop-types.js

@@ -420,6 +420,23 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
 
   invalid: [
     {
+      code: [
+        'var Hello = React.createClass({',
+        '  render: function() {',
+        '    return React.createElement("div", {}, this.props.name);',
+        '  }',
+        '});'
+      ].join('\n'),
+      ecmaFeatures: {
+        jsx: false
+      },
+      errors: [{
+        message: '\'name\' is missing in props validation',
+        line: 3,
+        column: 53,
+        type: 'Identifier'
+      }]
+    }, {
       code: [
         'var Hello = React.createClass({',
         '  render: function() {',