Skip to content

Commit 8626f72

Browse files
committed
fix detection of missing propTypes validations on ecmaFeatures.jsx false
1 parent 4a292d1 commit 8626f72

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

lib/rules/prop-types.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,12 @@ module.exports = function(context) {
509509
}
510510
markPropTypesAsDeclared(node, property.value);
511511
});
512+
513+
if (componentUtil.isComponentDefinition(node)) {
514+
componentList.set(context, node, {
515+
isReactComponent: true
516+
});
517+
}
512518
},
513519

514520
'Program:exit': function() {

tests/lib/rules/prop-types.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,23 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
420420

421421
invalid: [
422422
{
423+
code: [
424+
'var Hello = React.createClass({',
425+
' render: function() {',
426+
' return React.createElement("div", {}, this.props.name);',
427+
' }',
428+
'});'
429+
].join('\n'),
430+
ecmaFeatures: {
431+
jsx: false
432+
},
433+
errors: [{
434+
message: '\'name\' is missing in props validation',
435+
line: 3,
436+
column: 53,
437+
type: 'Identifier'
438+
}]
439+
}, {
423440
code: [
424441
'var Hello = React.createClass({',
425442
' render: function() {',

0 commit comments

Comments
 (0)