Feature: Save as dialog without the gui bits#213
Open
Maaxxs wants to merge 3 commits intojtheoof:masterfrom
Open
Feature: Save as dialog without the gui bits#213Maaxxs wants to merge 3 commits intojtheoof:masterfrom
Maaxxs wants to merge 3 commits intojtheoof:masterfrom
Conversation
Pressing the shortcut `Ctrl+Shift+s` allows to interactively select a directory and filename to save the current screenshot. Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
Maaxxs
force-pushed
the
feat/save_as_image-nogui
branch
from
d301bbd to
5336791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #133 this PR contains only the code for adding the
Ctrl+Shift+sshortcut to open a "save as" dialog. It doesn't contain the additional GUI button.The shortcut is documented in the ReadMe and man page.
The second commit contains an update of the po files for the GTK chooser dialog. @jtheoof Even though you said to remove this, I think we need this to provide translations. If you don't want this I can just drop the second commit.