Fix: Check webshot2 result for screenshot success in gtsave_extra#142
Open
mrembert wants to merge 1 commit intojthomasmock:masterfrom
Open
Fix: Check webshot2 result for screenshot success in gtsave_extra#142mrembert wants to merge 1 commit intojthomasmock:masterfrom
mrembert wants to merge 1 commit intojthomasmock:masterfrom
Conversation
The gtsave_extra function now correctly checks the return value of webshot2::webshot and uses file.exists() to verify that the screenshot was saved successfully. This avoids relying on capture.output(), which was not reliably capturing output from webshot2."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
This pull request addresses an issue where the
gtsave_extrafunction was not reliably detecting whether the screenshot was saved successfully when usingwebshot2::webshot. The original code relied onutils::capture.output(type = "message")to capture output fromwebshot2, but this was not working consistently, likely due to the asynchronous nature ofwebshot2and how it handles output from Chrome/Chromium.Proposed Solution
This PR modifies
gtsave_extrato use the return value ofwebshot2::webshot(which is the path to the saved screenshot file) andfile.exists()to check if the screenshot file was actually created. This provides a more robust and reliable way to determine if the screenshot operation was successful.Changes Made
gtsave_extrato usewebshot2::webshot's return value andfile.exists().utils::capture.output().This change ensures that
gtsave_extracorrectly reports success or failure when saving screenshots, improving the reliability of the function.