Skip to content

Some misc fixes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobsayshilol wants to merge 13 commits into
base: AprilTagTrackers
Choose a base branch
from
Open

Some misc fixes #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2b8b9ff
Fix a bug in the Ipc::Connection class
bobsayshilol Dec 11, 2022
56b8592
Remove unnecessary re-declaration of base class methods
bobsayshilol Dec 11, 2022
e003777
Add necessary cast to correct type
bobsayshilol Dec 11, 2022
69892b3
Always return a value from Key::isPressed()
bobsayshilol Dec 11, 2022
6bcaee6
Remove unused code
bobsayshilol Dec 11, 2022
b26f555
Introduce some types
bobsayshilol Dec 11, 2022
68d009f
Initialise _pose_timestamp
bobsayshilol Dec 11, 2022
4fb40c6
Simplify some Maths
bobsayshilol Dec 11, 2022
aa8d94c
Drop max_saved
bobsayshilol Dec 11, 2022
87e15cf
Add some thread safety to the trackers
bobsayshilol Dec 11, 2022
b00fd64
Add some useful log messages
bobsayshilol Dec 12, 2022
0ab2110
Use the correct member for the trackers/stations list
bobsayshilol Dec 13, 2022
551095f
Return the rate at which the pose is changing
bobsayshilol Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions driver_files/src/Driver/IVRDevice.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@ namespace ExampleDriver {
return out_pose;
}

// Inherited via ITrackedDeviceServerDriver
virtual vr::EVRInitError Activate(uint32_t unObjectId) = 0;
virtual void Deactivate() = 0;
virtual void EnterStandby() = 0;
virtual void* GetComponent(const char* pchComponentNameAndVersion) = 0;
virtual void DebugRequest(const char* pchRequest, char* pchResponseBuffer, uint32_t unResponseBufferSize) = 0;
virtual vr::DriverPose_t GetPose() = 0;

~IVRDevice() = default;
};
};
2 changes: 1 addition & 1 deletion driver_files/src/Driver/IVRDriver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace ExampleDriver {

typedef std::variant<std::monostate, std::string, int, float, bool> SettingsValue;

class IVRDriver : protected vr::IServerTrackedDeviceProvider {
class IVRDriver : public vr::IServerTrackedDeviceProvider {
public:

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion driver_files/src/Driver/Key.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ namespace Key {
}
#else
(void)key;
return false;
#endif
return false;
}

}; // namespace Key
Loading