Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
this makes the client show the error
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request refactors the astrometric calibration system to support arbitrary binnings and implements photo-polarimetry support for DIPOL instrument. The changes enable binning-independent pixel calculations and add magnitude computation capabilities to DIPOL polarimetry observations.
Changes:
- Refactored astrometry calibration to remove
allskyparameter and improve position hint handling with automatic detection of pointing mismatches - Implemented support for arbitrary binnings through
reference_binningclass attribute and binning-independent pixel calculation methods - Added DIPOL photo-polarimetry support with magnitude computation and calibration for polarimetry observations
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_generic.py | Formatting fix (trailing whitespace) |
| iop4lib/utils/sourcepairing.py | Added get_pairs_dxy_sign function for signed displacement pair finding; updated docstrings |
| iop4lib/utils/sourcedetection.py | Formatting fix (trailing whitespace) |
| iop4lib/utils/astrometry.py | Refactored to split parameter generation from WCS building; removed allsky parameter; added automatic position hint adjustment for pointing mismatches |
| iop4lib/utils/init.py | Updated Simbad API calls to use lowercase column names; improved build_wcs_centered_on error handling; added debug logging for magnitude calibration |
| iop4lib/iop4.py | Added filtering of .bak files in file listing functions |
| iop4lib/instruments/instrument.py | Added binning support methods; new abstract classify_juliandate_rawfit method; improved centroiding with Gaussian smoothing; added exception handling for aperture photometry |
| iop4lib/instruments/osn_cameras.py | Removed allsky parameter from get_astrometry_position_hint; improved warning messages for source mismatches |
| iop4lib/instruments/dipol.py | Implemented binning-independent calculations; added magnitude computation to polarimetry; refactored build_shotgun_params; improved photometry field selection logic |
| iop4lib/instruments/dipol_astrometry.yaml | Added TDE source type rules; added condition to check for non-null photometry reference |
| iop4lib/instruments/cafos.py | Refactored build_shotgun_params to return param dictionaries directly; removed allsky parameter |
| iop4lib/db/reducedfit.py | Added hint_disp_sign_mean property; removed allsky parameter from get_astrometry_position_hint |
| iop4lib/db/rawfit.py | Added instrument_cls and hint_disp_sign_mean properties; formatting fixes |
| iop4lib/db/photopolresult.py | Added datetime property; removed unused variable |
| iop4lib/db/fitfilemodel.py | Removed trailing whitespace |
| iop4lib/db/epoch.py | Added filtering of .bak files when listing local files |
| iop4lib/db/astrosource.py | Added is_calibrator property with caching mechanism |
| iop4lib/db/aperphotresult.py | Updated to use hint_disp_sign_mean property; reordered plot elements |
| iop4lib/config.example.yaml | Removed deprecated astrometry_allsky_allow and astrometry_allsky_septhreshold configuration options |
| iop4api/views/plot.py | Moved df_crosscheck initialization inside conditional block to avoid unnecessary DataFrame creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as off-topic.
This comment was marked as off-topic.
juanep97
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Details
Per-file overview (adapted from copiot review):iop4lib/utils/sourcepairing.pyget_pairs_dxy_signfunction for signed displacement pair finding; updated docstringsiop4lib/utils/astrometry.pyallskyparameter; added automatic position hint adjustment for pointing mismatchesiop4lib/iop4.py.bakfiles in file listing functionsiop4lib/instruments/instrument.pyclassify_juliandate_rawfitmethod; improved centroid finding; added exception handling for aperture photometryiop4lib/instruments/osn_cameras.pyallskyparameter fromget_astrometry_position_hint; improved warning messages for source mismatchesiop4lib/instruments/dipol.pybuild_shotgun_params; improved photometry field selection logiciop4lib/instruments/dipol_astrometry.yamliop4lib/instruments/cafos.pybuild_shotgun_params; removedallskyparameteriop4lib/db/reducedfit.pyhint_disp_sign_meanproperty; removedallskyparameter fromget_astrometry_position_hintiop4lib/db/rawfit.pyinstrument_clsandhint_disp_sign_meanproperties; formatting fixesiop4lib/db/photopolresult.pydatetimeproperty; removed unused variableiop4lib/db/epoch.py.bakfiles when listing local filesiop4lib/db/astrosource.pyis_calibratoras an object property, with caching mechanismiop4lib/db/aperphotresult.pyhint_disp_sign_meanproperty; reordered plot elementsiop4lib/config.example.yamlastrometry_allsky_allowandastrometry_allsky_septhresholdconfiguration optionsiop4api/views/plot.pydf_crosscheckinitialization inside conditional block to avoid unnecessary DataFrame creationiop4lib/utils/__init__.pybuild_wcs_centered_onerror handling; added debug logging for magnitude calibration