Add ExtendNodeExpiration functionality to gRPC and CLI #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Apologies for missing this among other PRs and work, can you rebase this? It will need some integration tests tho to validate that the expected behaviour happens. |
FlorinPeter
force-pushed
the
add-extend-expiration
branch
from
c73ba08 to
3689639
Compare
Pull Request Revisions
✅ AI review completed for r2 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
ghost
approved these changes
Jul 23, 2025
This commit adds the ability to extend node expiration through both gRPC API and CLI commands, including: - New gRPC ExtendNodeExpiration method with validation - CLI extend-expiration command with proper error handling - Expiration upper bound validation (max 2 years from current time) - Updated generated protobuf files with proper body consumption - Appropriate notifications for expiration changes
FlorinPeter
force-pushed
the
add-extend-expiration
branch
from
3689639 to
c9d7f25
Compare
ghost
approved these changes
Jul 23, 2025
Author
|
@kradalby sorry the message was drowned in my inbox, it is rebased now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ExtendNodeExpiration RPC, allowing users to extend a node's expiration. Update the CLI to include the
extend-expirationcommand with required fields. Validate inputs, update the database, and notify peers of expiration changes.