Skip to content

Conversation

@JanWilczek
Copy link
Collaborator

No description provided.

@reuk
Copy link
Member

reuk commented Oct 22, 2025

Looks good, just a few ideas:

  • Consider requiring a double-click instead of a single-click to open the about popup, to avoid accidentally opening the popup when mis-clicking on the waveform selector.
  • Maybe you could pass the top-level component into the constructor of MessageOnClick to avoid needing to query the target component's parent. I think this would end up being more concise.
  • Could we set the bubble component background and border to match the theme of the rest of the plugin?

@JanWilczek
Copy link
Collaborator Author

Looks good, just a few ideas:

  • Consider requiring a double-click instead of a single-click to open the about popup, to avoid accidentally opening the popup when mis-clicking on the waveform selector.
  • Maybe you could pass the top-level component into the constructor of MessageOnClick to avoid needing to query the target component's parent. I think this would end up being more concise.
  • Could we set the bubble component background and border to match the theme of the rest of the plugin?

These are very good points, thanks. I have implemented them all and updated the lesson description. Please, check.

Copy link
Member

@reuk reuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well and looks nice, good job 👍

I just spotted one potential issue, but it should be simple to resolve so I'm hitting "approve" now.

@JanWilczek JanWilczek merged commit b7ada28 into main Oct 24, 2025
4 checks passed
@JanWilczek JanWilczek deleted the jan/change-up-popup branch November 3, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants