Different Folder structure but added mutations#4
Open
rchvalbo wants to merge 25 commits intojuffalow:masterfrom
Open
Different Folder structure but added mutations#4rchvalbo wants to merge 25 commits intojuffalow:masterfrom
rchvalbo wants to merge 25 commits intojuffalow:masterfrom
Conversation
removed id for auto increment
Owner
|
There are lot of commits in your pull request. It would be better to rebase them into one. I agree the input types are very small and easy, but I wanted to show the developer that he / she can separate it. I know it is obvious for lot of developers that you can put those things into separate files, but... I was on lot of projects that had everything in one file and it was not readable, therefore I always do it like this in my example projects. And I am sorry, this time I added it here by myself. But please, stay in touch and maybe there will be another issue you can hep with. Thank you! |
juffalow
force-pushed
the
master
branch
2 times, most recently
from
809ebe4 to
4798bc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up removing the input types that weren't necessary. I didn't create another folder for inputs due to their simplicity. It would be much easier to understand their usage when they are directly within the file in which they are used.